Update dispute game contracts for oplabs-devnet-0 and op-sepolia #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inphi
force-pushed
the
inphi/sep-dev-0
branch
2 times, most recently
from
4bb2067 to
49ce28c
Compare
Inphi
changed the title
Inphi
force-pushed
the
inphi/sep-dev-0
branch
2 times, most recently
from
0b14019 to
e2de554
Compare
Inphi
force-pushed
the
inphi/sep-dev-0
branch
from
e2de554 to
87a4db3
Compare
sebastianst
reviewed
Dec 20, 2024
There was a problem hiding this comment.
I believe ethereum-optimism/superchain-ops#421 will change some addresses for op-sepolia again.
|
@Inphi is this still relevant? |
This is still relevant as the dispute game addresses are out of date on op networks. I'll rebase the work on top of the latest changes in a couple days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the dispute game contracts for the oplabs sepolia devnet and op-sepolia.
This also adds
PermissionedDelayedWETH, andMIPS64to the chain addresses.Context for MIPS64 Superchain Upgrades
The
CANNONandPERMISSIONED_CANNONgame implementations will be replaced with new implementations that use the MIPS64 VM. MIPS64 is effectively the oldMIPSVM. The MIPS64.sol contract semver precedes the MIPS.sol semver and so a new MIPS64 config value is added to prevent the backwards semver check from failing in CI.This is awkward as it's no longer clear which VM implementation is used by a chain from looking at the superchain-registry. This awkwardness is temporary as once the superchain upgrades to MIPS64, we can remove the
MIPS64config field by replacing theMIPSconfig value with a deployed MIPS64 contract address.The op-program prestate releases are agnostic to type of VM used to generate the prestate. That is, given a absolute prestate hash in the release registry, it's either a MIPS or MIPS64 generated prestate but not both. This creates a problem during FP validation checks as the op-sepolia MIPS64 upgrade was based on the
op-program/v1.4.0-rc.3release. And the prestate of that release already exists in the registry as a MIPS prestate.To workaround this issue, FP validation is tweaked to avoid checking the absolute prestate on testnets that use MIPS64. This workaround can be removed once OPCM manages upgrades.